Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting of XML comments for ISymbol #18558

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Conversation

svick
Copy link
Contributor

@svick svick commented Apr 8, 2017

Viewing long plaintext XML comments using a tool like ReSharper's Ctrl+Q or DotNetApis is hard, because all the text is considered a single paragraph with no formatting.

This PR fixes that for ISymbol, but it's also a plea to reconsider the closing of #85: if even the authors of C# cannot be bothered to format their XML comments properly, what makes you think other programmers will?

cc: @MadsTorgersen

@Pilchie Pilchie added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Apr 13, 2017
@Pilchie
Copy link
Member

Pilchie commented Apr 13, 2017

Tagging @dotnet/roslyn-compiler for review.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.

@jaredpar jaredpar merged commit dac3797 into dotnet:master Apr 28, 2017
@svick svick deleted the symbol-xml branch April 29, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers cla-already-signed Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants